Don't perform any EOL conversions on VBA files #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in this comment, the current
.gitattributesconfigurations makes it so that anyone who clones the project will see that it has pending changes. That's because Git will normalize the CRLF inside the working tree to LF in the Index.These new configurations will ensure that VBA code files keep their CRLF line endings in both the working tree and the index1.
See also: Does the use of -text affect how Git performs diffs?
Closes #56
Footnotes
This remains true as long as VBA files are produced by exporting them from the VBE. If someone create a new VBA file from an IDE configured to use LF, these line endings won't be converted to CRLF. This is quite unlikely unless you expect a lot of contributors to work with a UNIX/Linux machine. If you want to be 100% sure no LFs are introduced by mistake, there is always this action that can be used: https://github.com/marketplace/actions/enforce-crlf. ↩